> On Jan. 18, 2019, 12:03 p.m., Benjamin Bannier wrote: > > src/examples/test_csi_plugin.cpp > > Line 1025 (original), 1168 (patched) > > <https://reviews.apache.org/r/69787/diff/1/?file=2120294#file2120294line1187> > > > > nit: Not this patch, but this is the default and not required in C++. > > Chun-Hung Hsiao wrote: > Could you explain more? Do you mean I should do `return 0` instead?
You could just remove this line, https://en.cppreference.com/w/cpp/language/return#Notes. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69787/#review212136 ----------------------------------------------------------- On Jan. 25, 2019, 1:35 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69787/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2019, 1:35 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9517 > https://issues.apache.org/jira/browse/MESOS-9517 > > > Repository: mesos > > > Description > ------- > > If the `--forward` flag is set, the test CSI plugin would forward all gRPC > requests to the specified gRPC server URI, and return the response to > the caller. This can be used to forward all CSI calls to a mock CSI > plugin object in the test process. > > > Diffs > ----- > > src/examples/test_csi_plugin.cpp af183037b280bab65578a4c447196a9ccf261e32 > > > Diff: https://reviews.apache.org/r/69787/diff/3/ > > > Testing > ------- > > Manually tweaked the plugin to forward requests to itself and all tests pass. > > > Thanks, > > Chun-Hung Hsiao > >
