> On Jan. 25, 2019, 5:34 p.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 4853 (patched) > > <https://reviews.apache.org/r/69815/diff/4/?file=2122136#file2122136line4853> > > > > Do we need this for synchronization?
No we don't. I just added it to check the operation UUID, but it might be unnecessary. I'll remove it to simplify the test. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69815/#review212337 ----------------------------------------------------------- On Jan. 25, 2019, 3:29 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69815/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2019, 3:29 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9517 > https://issues.apache.org/jira/browse/MESOS-9517 > > > Repository: mesos > > > Description > ------- > > This patch adds a unit test to verify that SLRP will retry > `CreateVolume` and `DeleteVolume` CSI calls with a random exponential > backoff upon receiving `DEADLINE_EXCEEDED` or `UNAVAILABLE`. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > e8ed20f818ed7f1a3ce15758ea3c366520443377 > > > Diff: https://reviews.apache.org/r/69815/diff/4/ > > > Testing > ------- > > make check > > TODO: Will make the test more robust and add testing for `DESTROY_DISK`. > > > Thanks, > > Chun-Hung Hsiao > >
