----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69812/#review212381 -----------------------------------------------------------
Fix it, then Ship it! Ship It! src/resource_provider/storage/provider.cpp Lines 1956 (patched) <https://reviews.apache.org/r/69812/#comment298149> `stout/unreachable.hpp` - Benjamin Bannier On Jan. 26, 2019, 1:21 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69812/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2019, 1:21 a.m.) > > > Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan > Schlicht. > > > Bugs: MESOS-9517 > https://issues.apache.org/jira/browse/MESOS-9517 > > > Repository: mesos > > > Description > ------- > > For CSI calls triggered by offer operations, i.e., `CreateVolume` and > `DeleteVolume`, if the plugin returns retryable errors (`UNAVAILABLE` or > `DEADLINE_EXCEEDED`), SLRP will now retry indefinitely with a random > exponential backoff. With this, frameworks will know that the operations > are terminated with deterministic volume states when getting > `OPERATION_FAILED`. > > > Diffs > ----- > > src/csi/client.hpp 5d40d54c2abbd03993ce8835d37db23e209c7554 > src/csi/client.cpp 61ed410985099828a2f58b1527ab57daa4b379df > src/resource_provider/storage/provider.hpp > 331f7b785b14b814c2889488effd53f3a48a1b95 > src/resource_provider/storage/provider.cpp > d6e20a549ede189c757ae3ae922ab7cb86d2be2c > > > Diff: https://reviews.apache.org/r/69812/diff/3/ > > > Testing > ------- > > make check > > A unit test will be added later in the chain. > > > Thanks, > > Chun-Hung Hsiao > >
