> On Jan. 30, 2019, 5:09 p.m., Benjamin Mahler wrote: > > Thanks! Probably don't need the duplicate description in the commit message?
The way we have our reviewboard interaction set up, not manually adjusting a redundant description is actually the easier way: During post-review it gets populated automatically with the summary, and apply-review removes the redundant information again. https://github.com/apache/mesos/commit/69c918a72aa7e15ce12f8afc12203a115c4cd634 - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69861/#review212452 ----------------------------------------------------------- On Jan. 30, 2019, 4:03 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69861/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2019, 4:03 p.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Repository: mesos > > > Description > ------- > > Declared `HierarchicalAllocatorProcess::allocatable` `const`. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > ca1638390d89e2a81efd9d6d4a28b863c79723c4 > src/master/allocator/mesos/hierarchical.cpp > f1f3894058a8e3f008013cb269744bd36c0e31b3 > > > Diff: https://reviews.apache.org/r/69861/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
