----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69820/#review212458 -----------------------------------------------------------
Patch looks great! Reviews applied: [69861, 69818, 69819, 69820] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Jan. 29, 2019, 4:20 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69820/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2019, 4:20 p.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9523 > https://issues.apache.org/jira/browse/MESOS-9523 > > > Repository: mesos > > > Description > ------- > > This patch adds `contains` function for `ResourceQuantities`. The > function has the same semantics as `Resources::contains`. > > > Diffs > ----- > > src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd > src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f > src/tests/resource_quantities_tests.cpp > 435a4949b95e9a83be73781388eb4be9c7da695b > > > Diff: https://reviews.apache.org/r/69820/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
