----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69876/#review212491 -----------------------------------------------------------
PASS: Mesos patch 69876 was successfully built and tested. Reviews applied: `['69876']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2842/mesos-review-69876 - Mesos Reviewbot Windows On Jan. 31, 2019, 11:08 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69876/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2019, 11:08 p.m.) > > > Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Gastón > Kleiman. > > > Bugs: MESOS-9535 > https://issues.apache.org/jira/browse/MESOS-9535 > > > Repository: mesos > > > Description > ------- > > When an agent is downgraded from one with the AGENT_OPERATION_FEEDBACK > capability to one without this capability, the master needs to remove > terminal-but-unACKed operations from its state which operate on agent > default resources, since the downgraded agent will not resend status > updates for these operations. > > > Diffs > ----- > > src/master/master.cpp f74b7c280569e1c24e0940463bb28bd795d429d5 > src/tests/master_tests.cpp acc6096239e4992bdca084d88880d644ab4a2385 > > > Diff: https://reviews.apache.org/r/69876/diff/1/ > > > Testing > ------- > > `make check` > `bin/mesos-tests.sh --gtest_filter="*CleanupOperationsAfterAgentDowngrade*" > --gtest_repeat=-1 --gtest_break_on_failure` > > > Thanks, > > Greg Mann > >