----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69893/#review212558 -----------------------------------------------------------
src/resource_provider/storage/provider.cpp Lines 3137 (patched) <https://reviews.apache.org/r/69893/#comment298378> This is some pretty strong coupling to `master::validate` checking `resource::validatePersistentVolume`. That's probably okay, but would could also just re-validate here instead. src/resource_provider/storage/provider.cpp Lines 3125-3126 (original), 3138-3139 (patched) <https://reviews.apache.org/r/69893/#comment298379> Do we actually validate this somewhere? src/resource_provider/storage/provider.cpp Lines 3230 (patched) <https://reviews.apache.org/r/69893/#comment298380> Is this validated somewhere? src/resource_provider/storage/provider.cpp Lines 3234 (patched) <https://reviews.apache.org/r/69893/#comment298381> Is this validated? src/resource_provider/storage/provider.cpp Lines 3244 (patched) <https://reviews.apache.org/r/69893/#comment298382> Does this break seemless upgrades? Probably okay, but still something worth documenting in the upgrades guide. - Benjamin Bannier On Feb. 5, 2019, 8:42 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69893/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2019, 8:42 a.m.) > > > Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. > > > Bugs: MESOS-9544 > https://issues.apache.org/jira/browse/MESOS-9544 > > > Repository: mesos > > > Description > ------- > > This patch limits SLRP to only support persistent volumes on MOUNT > disks, and makes it clean up data in persistent volumes when processing > `DESTROY` operations. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > d6e20a549ede189c757ae3ae922ab7cb86d2be2c > src/resource_provider/storage/provider_process.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/69893/diff/1/ > > > Testing > ------- > > `make check` > > More testing done later in chain. > > > Thanks, > > Chun-Hung Hsiao > >
