----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212785 -----------------------------------------------------------
Patch looks great! Reviews applied: [69900, 69902, 69818, 69862, 69889, 69821, 69890] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Feb. 11, 2019, 7:46 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69890/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2019, 7:46 a.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9523 > https://issues.apache.org/jira/browse/MESOS-9523 > > > Repository: mesos > > > Description > ------- > > This patch adds tests for the behavior of per-framework, per-role > minimal allocatable resources. We validate the behavior of framework > minimal allocatable resources below the globally configured limits and > the behavior of empty filters or minimal resource quantities set up for > a framework. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > cc88afbad1b4e6bf707cb13b50c964aa01f9a3ee > > > Diff: https://reviews.apache.org/r/69890/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >