----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69980/#review212818 -----------------------------------------------------------
PASS: Mesos patch 69980 was successfully built and tested. Reviews applied: `['69960', '69961', '69962', '69963', '69967', '69980']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2887/mesos-review-69980 - Mesos Reviewbot Windows On Feb. 13, 2019, 3:23 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69980/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2019, 3:23 p.m.) > > > Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann. > > > Bugs: MESOS-9542 > https://issues.apache.org/jira/browse/MESOS-9542 > > > Repository: mesos > > > Description > ------- > > When dealing with orphaned operation status updates, there are two > cases the master must deal with: > - The simple case is when the master knows the framework is completed. > These status updates can be acknowledged by the master. > - However, a completed framework can be rotated out of the master's > memory. In addition, after master failover, if an agent reregisters > before the framework, an operation can appear to be orphaned until > the framework reregisters. > > This adds a fixed delay between agent reregistration and when the > master acknowledges operation status updates from unknown frameworks. > The delay should give frameworks ample time to reregister. > > The delay is based on agent reregistration in order to mitigate the > delay of acknowledging status updates of frameworks rotated out of > the completed frameworks buffer. > > > Diffs > ----- > > src/master/constants.hpp b0ab9187b8c672180e2ffb8b63cb7349dbe43ac4 > src/master/master.cpp 014e0e053cdf5c53a5ef8d63300205a121bed319 > > > Diff: https://reviews.apache.org/r/69980/diff/1/ > > > Testing > ------- > > TODO: This case needs unit tests. > > > Thanks, > > Joseph Wu > >
