----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69981/#review212824 -----------------------------------------------------------
Patch looks great! Reviews applied: [69981] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Feb. 14, 2019, 12:27 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69981/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2019, 12:27 a.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Mahler. > > > Bugs: MESOS-9143 > https://issues.apache.org/jira/browse/MESOS-9143 > > > Repository: mesos > > > Description > ------- > > The test is flaky due to a race between metrics update > and metrics query. > > This patch adds clock settle to ensure quota update and > removal are fully processed (including metrics updates) before > continuing with the metrics query. > > > Diffs > ----- > > src/tests/master_quota_tests.cpp 354a9e988c3e4cdf94c99170d2abb7cb17f9e11a > > > Diff: https://reviews.apache.org/r/69981/diff/2/ > > > Testing > ------- > > Test ran continuously without failure > > > Thanks, > > Meng Zhu > >
