> On Feb. 13, 2019, 9:28 p.m., Andrei Budnik wrote: > > Thanks for the patch! > > I think we should implement a test for this. Otherwise, it would be very > > dangerous to _refactor_ this part of code in the future. > > If you have no chance to implement a test for this now, please feel free to > > file a ticket.
Sure, I posted a unit test here: https://reviews.apache.org/r/69994/ - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69972/#review212795 ----------------------------------------------------------- On Feb. 13, 2019, 4:26 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69972/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2019, 4:26 p.m.) > > > Review request for mesos, Andrei Budnik and Gilbert Song. > > > Bugs: MESOS-9507 > https://issues.apache.org/jira/browse/MESOS-9507 > > > Repository: mesos > > > Description > ------- > > There are two cases we need to handle: > 1. The checkpointed docker volumes file does not exist. > 2. The checkpointed docker volumes file is empty. > For both of the two cases, in the recovery of `docker/volume` isolator, > we should remove the container's checkpoint directory and then skip the > container. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > a72fc84da6fb0f24d363dd4c635500510da675d8 > > > Diff: https://reviews.apache.org/r/69972/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >