-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70000/
-----------------------------------------------------------
(Updated Feb. 19, 2019, 11:43 a.m.)
Review request for mesos, Till Toenshoff and Vinod Kone.
Changes
-------
Translate error from not applying patch to `ReviewError`
Bugs: MESOS-9582
https://issues.apache.org/jira/browse/MESOS-9582
Repository: mesos
Description
-------
Previously `support/verify-reviews.py` would abort prematurely
whenever a review a patch could not be applied. This was due to
the `shell` function used to call `support/apply-reviews.py` invoking
`exit(1)` on the first error which stopped iteration over all
outstanding reviews.
In this patch that explicit call to `exit` is removed, and instead we
let a possible `subprocess.CalledProcessError` propagate up for it to
be handled at a higher level. Currently this will post a note on the
review in question to (1) notify the submitter, and (2) prevent the
review from being checked again.
With the changes here the script will not stop verify reviews in such
cases.
Diffs (updated)
-----
support/verify-reviews.py a88a91f8ecb3794846d2d5eddee27ada770d55b9
Diff: https://reviews.apache.org/r/70000/diff/2/
Changes: https://reviews.apache.org/r/70000/diff/1-2/
Testing
-------
Ran the script (with a dummy user and password) on today's reviewboard state.
The script attempted to post a review on the last patch in the chain instead of
aborting (see the `TODO` in the code on why we weren't able to diagnose the
issue in the faulty patch with the current implementation).
Thanks,
Benjamin Bannier
