----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70046/#review213124 -----------------------------------------------------------
Patch looks great! Reviews applied: [70046] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Feb. 23, 2019, 12:41 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70046/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2019, 12:41 p.m.) > > > Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao. > > > Repository: mesos > > > Description > ------- > > During the refactoring of `d838f2958e` we reorganized the code flow to > propagate failures from `os::close` and introduce code which migh > close an invalid file descriptor. While this would produce an `Error` > result from `mktemp` in any case, it would have lead to confusing > error messages in that scenario. This patch prevents closing invalid > file descriptors altogether which is consistent with the > pre-refactoring behavior. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/mktemp.hpp > 8dab2599f13c3e1dab109423c8a938ec16540aaf > > > Diff: https://reviews.apache.org/r/70046/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
