-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70047/
-----------------------------------------------------------
(Updated Feb. 25, 2019, 2:35 a.m.)
Review request for mesos, Benjamin Bannier and Joseph Wu.
Bugs: MESOS-9605
https://issues.apache.org/jira/browse/MESOS-9605
Repository: mesos
Description
-------
For autotools, we extracted additional build info like the git branch
and sha during the automake phase handing them into libbuild via
commandline defines.
CMake builds however used a configuration file for this purpose.
This patch updates both build systems to make use of
build_config.hpp.in for build specific configuration artefacts.
Diffs
-----
cmake/CompilationConfigure.cmake c330324e2e3dea6e71980ae8c9ed71632ebb018e
configure.ac ee29fc784e53ebaf1bb016c33136b200c646ee9b
src/Makefile.am 283d5ed89b36d74da36f38c26aec03c6129d6261
src/common/build.cpp f5271d87d33ac429fb94093a347be1d6c25d3432
src/common/build_config.hpp.in 4cce2403c1d7a5feee8fd2fffa7cf4308507cd0c
Diff: https://reviews.apache.org/r/70047/diff/1/
Testing (updated)
-------
manually tested both cmake and autotools.
WIP: A test using the centos RPM toolchain does not yield the intended result;
```
[root@9b0d899ff4c6 ~]# mesos-slave --work_dir=/tmp --master=127.0.0.1:5050
I0225 02:30:16.113528 97 main.cpp:350] Build: 2019-02-25 01:59:55 by centos
I0225 02:30:16.113606 97 main.cpp:351] Version: 1.8.0
I0225 02:30:16.121173 97 systemd.cpp:240] systemd version `219` detected
I0225 02:30:16.121199 97 main.cpp:453] Initializing systemd state
E0225 02:30:16.121251 97 main.cpp:462] EXIT with status 1: Failed to
initialize systemd: Failed to locate systemd runtime directory:
/run/systemd/system
```
It still lacks the SHA!
Thanks,
Till Toenshoff
