> On Feb. 25, 2019, 11:43 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > > Lines 889 (patched) > > <https://reviews.apache.org/r/69544/diff/5/?file=2117980#file2117980line890> > > > > we called update in multiple places in slave.cpp, is it true that for > > PV, the update would only be invoked once? > > > > Also, does it hurt if our volumeGidManager invokes allocate a > > particular `path` multiple times?
> we called update in multiple places in slave.cpp, is it true that for PV, the > update would only be invoked once? The `update` method will be called twice: 1. Called by `prepare` method. 2. Called when the executor registers agent. For command executor, volume gid manager will be called in #1 and #2 is just a no-op (because there is no resource changes, i.e., nothing to update). For default executor, volume gid manager will be called in #2 and #1 is just a no-op (because default executor itself has no PV specified but the task's PV resources will be merged to it in #2). > Also, does it hurt if our volumeGidManager invokes allocate a particular path > multiple times? It will not hurt because in that case volume gid manager will find the volume path has been already allocated with a gid and just return that gid to caller. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69544/#review213132 ----------------------------------------------------------- On Jan. 7, 2019, 8:49 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69544/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2019, 8:49 a.m.) > > > Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya > Pronin, and Jie Yu. > > > Bugs: MESOS-8813 > https://issues.apache.org/jira/browse/MESOS-8813 > > > Repository: mesos > > > Description > ------- > > Made non-root containers can access shared persistent volume. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > a5cf2da55c046c5c45e0c2ca3400f64de12de62b > src/slave/containerizer/mesos/isolators/filesystem/linux.hpp > 8f76944cd9058c0ba809443e32a3d8c8a26ac4a6 > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > 2a9ea448d7f963f86e8b2909d83e82b498e4104c > src/slave/containerizer/mesos/isolators/filesystem/posix.hpp > deacc909a2d323671667cb646c019664bdb660e7 > src/slave/containerizer/mesos/isolators/filesystem/posix.cpp > f91a2eeb835bb65a855eeb314d4c69e3b58fecae > src/slave/containerizer/mesos/isolators/filesystem/windows.hpp > 2bf011d3e7b014a17f759851d755b161c897b131 > src/slave/containerizer/mesos/isolators/filesystem/windows.cpp > f169c380f803a2111b1612cee60250ee9a30ef2e > src/slave/volume_gid_manager/volume_gid_manager.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/69544/diff/5/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >