> On Feb. 25, 2019, 10:15 p.m., Benjamin Bannier wrote: > > How is this patch related to https://reviews.apache.org/r/69542/? Some > > issues were raised over there and a discussion started. We should strongly > > avoid loosing such context as it makes it harder to understand patches > > later.
That patch was discarded because we changed our solution after offline discussion, I will describe why we discarded it in https://reviews.apache.org/r/69542/ , sorry for the confusion. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/#review213165 ----------------------------------------------------------- On Feb. 26, 2019, 10:54 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69345/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2019, 10:54 a.m.) > > > Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya > Pronin, and Jie Yu. > > > Bugs: MESOS-8810 > https://issues.apache.org/jira/browse/MESOS-8810 > > > Repository: mesos > > > Description > ------- > > If a nested container running as a non-root user tries to use a PARENT > type SANDBOX_PATH volume, we will make sure the volume owned by a unique > gid allocated by the volume gid manager and the container process > launched with that gid as its supplementary group. > > > Diffs > ----- > > include/mesos/slave/containerizer.proto > 7d16463fcce3df14d256f5a4f2deb42c482d0734 > src/local/local.cpp 608706811486e59b9472c026876d1d84cbccc279 > src/slave/containerizer/containerizer.hpp > 66f73a306deffc51503479420531ea1948c574e1 > src/slave/containerizer/containerizer.cpp > c6b5e64a72d16b871dcbfc17c05566affea6bd44 > src/slave/containerizer/mesos/containerizer.hpp > 263a17701da694bad5153e29143b75d0ab75f468 > src/slave/containerizer/mesos/containerizer.cpp > 5e6b3540da9bd75ea4b73846d477652ff80237ad > src/slave/containerizer/mesos/isolators/volume/sandbox_path.hpp > 1631160236379f84c6e1ed1be1370b5f2f2fd563 > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp > ecd467c5a33c2f41396bc72ddd7cb806bb8adc52 > src/slave/containerizer/mesos/launch.cpp > 17dd67175cd27b665342394981e241ad36b98f96 > src/slave/main.cpp d1ce45455f2867cb71378da122fbd598aca4546d > src/slave/slave.hpp 7ad495504e4ff144ac31812fbd4a3a1f4da86f02 > src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79 > src/tests/cluster.cpp 61489840fb1491ab56fd9edd5bcbb1c1dca2c0d2 > src/tests/mock_slave.hpp 3c0d602a981d76dcf10f9e413851e606d835e113 > src/tests/mock_slave.cpp a78ca9c7911bb7928a93be6867abe62e8cd20712 > > > Diff: https://reviews.apache.org/r/69345/diff/7/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
