-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70040/
-----------------------------------------------------------

(Updated Feb. 26, 2019, 11:25 a.m.)


Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.


Changes
-------

Comment tweak!


Bugs: MESOS-9542
    https://issues.apache.org/jira/browse/MESOS-9542


Repository: mesos


Description
-------

This test covers a corner case where an agent reregisters with the
master with a pending operation, but the operation's originating
framework is unknown.  This can occur in a variety of situations like:
  * the master fails over and a framework never reregisters,
  * a completed framework is rotated out of the master's memory with
    pending operations, or
  * an agent with pending operations is migrated from one cluster to
    another.

In this case, the master should "adopt" the orphan operation only
after a delay.  This gives the framework some time to reregister.
But if the framework does not reregister in time, the master will
be in charge of acknowledging operation status updates.


Diffs (updated)
-----

  src/tests/storage_local_resource_provider_tests.cpp 
a661951a0a326cc342aa0c45dd0967692ae70941 


Diff: https://reviews.apache.org/r/70040/diff/3/

Changes: https://reviews.apache.org/r/70040/diff/2-3/


Testing
-------

```
make check
src/mesos-tests --gtest_filter="*TerminalOrphanOperationAfterMasterFailover*" 
--verbose
src/mesos-tests --gtest_filter="*Operation*" --verbose
```

(Internal CI run pending)


Thanks,

Joseph Wu

Reply via email to