----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70098/#review213514 -----------------------------------------------------------
Ship it! Ship It! - Alexander Rukletsov On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70098/ > ----------------------------------------------------------- > > (Updated March 3, 2019, 1:01 a.m.) > > > Review request for mesos and Armand Grillet. > > > Repository: mesos > > > Description > ------- > > This change removes explicit tracking of a patch against upstream > cpplint in the tree and replaces it with a clear reference against the > upstream repository and revision used in the modified file. > > The patch was never used by us against any upstream version, and was > not e.g., a legal requirement. The process around creating the patch > was cumbersome and error prone. Removing the patch from the tree > should not only make it easier to evolve our modifications going > forward, but also remove a lot of noise from changes. > > > Diffs > ----- > > support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 > support/cpplint.py d3e7aaf71255cf4efd0239434f7630afd6ea47d0 > > > Diff: https://reviews.apache.org/r/70098/diff/2/ > > > Testing > ------- > > N/A > > > Thanks, > > Benjamin Bannier > >
