-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70154/
-----------------------------------------------------------
(Updated March 7, 2019, 2:41 p.m.)
Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
Changes
-------
Push handling to a smaller scope, refactor an additional handler
Summary (updated)
-----------------
Properly handled disk resources in operator API `CREATE` handler.
Bugs: MESOS-9637
https://issues.apache.org/jira/browse/MESOS-9637
Repository: mesos
Description (updated)
-------
This code was previously assuming that any `CREATE` operation would add
a `DiskInfo` to resources (to hold the `PersistenceInfo`). To compute
the resources required to perform the operation it then just removed the
full `DiskInfo`. This is incorrect as e.g., CSI disk resources carry
information unrelated to persistence in their `DiskInfo`.
This patch fixes `CREATE` handling by leveraging resource conversions
which were introduced in the meantime. This allows extracting the
required resource in a lower scope which allows us refactor handlers for
other operator API calls. With that less information about the layout of
operations is needed here.
Diffs (updated)
-----
src/master/http.cpp 012ee4f205ab3f2678b058fb0f3ebdac4336eca4
src/master/master.hpp 90e08149ece595147ca4a93da215385917a0f372
Diff: https://reviews.apache.org/r/70154/diff/2/
Changes: https://reviews.apache.org/r/70154/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
