> On March 7, 2019, 11:49 p.m., Gastón Kleiman wrote: > > src/tests/utils.hpp > > Lines 39 (patched) > > <https://reviews.apache.org/r/70156/diff/1/?file=2129554#file2129554line39> > > > > Nit: I'd name this `EXPECT_METRIC_EQ`.
Fair point, I've used `metricEquals()` now that it isn't a macro anymore. - Benno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70156/#review213540 ----------------------------------------------------------- On March 8, 2019, 11:46 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70156/ > ----------------------------------------------------------- > > (Updated March 8, 2019, 11:46 p.m.) > > > Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > This patch adds a new helper function to check > whether a given metric has some specified value. > > > Diffs > ----- > > src/tests/utils.hpp b2f22cd4db223d167aa35109cd8de6df82ed1f4d > > > Diff: https://reviews.apache.org/r/70156/diff/2/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
