----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70062/#review213599 -----------------------------------------------------------
src/common/resource_quantities.hpp Lines 109-111 (original), 112-115 (patched) <https://reviews.apache.org/r/70062/#comment299578> Do we still need this now that we're splitting the class? Maybe remove it for now or make it return non-option `Value::Scalar` and None becomes 0? src/common/resource_quantities.cpp Lines 155 (patched) <https://reviews.apache.org/r/70062/#comment299574> Looks like this insertion may invalidate the iterator, we could write these loops using indexes instead of iterators? src/common/resource_quantities.cpp Lines 189 (patched) <https://reviews.apache.org/r/70062/#comment299575> zero and negative? src/common/resource_quantities.cpp Lines 190 (patched) <https://reviews.apache.org/r/70062/#comment299576> Ditto here, let's use indexes? src/common/resource_quantities.cpp Line 141 (original), 204 (patched) <https://reviews.apache.org/r/70062/#comment299577> Maybe we could have an `add(name, value)` function that replaces this to avoid the brittleness of `[]` leaving a 0 entry and relying on the caller to increment it out of the 0 state? - Benjamin Mahler On March 7, 2019, 2:35 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70062/ > ----------------------------------------------------------- > > (Updated March 7, 2019, 2:35 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9608 > https://issues.apache.org/jira/browse/MESOS-9608 > > > Repository: mesos > > > Description > ------- > > This patch removed the map interface of > `class ResourceQuantities`, added a few built-in > arithmetic operations. Now, absent resource items imply > there is no (zero) such resources. > > Also added a to-do to add `class ResourceLimits` which > is similar but treats absent resource entries as having > infinite amount of such resource. > > Also changed affected call sites and tests accordingly. > > > Diffs > ----- > > src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae > src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7 > src/master/allocator/sorter/drf/sorter.hpp > e64c9ad3520a601f7854e807ef5306d5bffc0ff8 > src/master/allocator/sorter/drf/sorter.cpp > b128df08e3c93d3d1a75c637cbed359c2cb8cda4 > src/master/allocator/sorter/random/sorter.hpp > 4f230ec740e2f80d5333c61c5b23d9a631bdb273 > src/master/allocator/sorter/random/sorter.cpp > f578ef19b4dee9cf9c7c99a8988829ecde70ed6d > src/tests/resource_quantities_tests.cpp > 435a4949b95e9a83be73781388eb4be9c7da695b > > > Diff: https://reviews.apache.org/r/70062/diff/3/ > > > Testing > ------- > > make check > Dedicated tests are added in the subsequent patch. > > > Thanks, > > Meng Zhu > >
