----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70152/#review213607 -----------------------------------------------------------
Ship it! src/tests/resource_quantities_tests.cpp Lines 389-427 (patched) <https://reviews.apache.org/r/70152/#comment299594> Ditto here for naming, although I guess we have to think of some names that suggest the semantics? E.g. empty -> infinite and some -> finite - Benjamin Mahler On March 7, 2019, 8:03 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70152/ > ----------------------------------------------------------- > > (Updated March 7, 2019, 8:03 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9608 > https://issues.apache.org/jira/browse/MESOS-9608 > > > Repository: mesos > > > Description > ------- > > Added tests for `ResourceLimits`. > > > Diffs > ----- > > src/tests/resource_quantities_tests.cpp > 435a4949b95e9a83be73781388eb4be9c7da695b > > > Diff: https://reviews.apache.org/r/70152/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
