asekretenko commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo. URL: https://github.com/apache/mesos/pull/326#discussion_r264652265
########## File path: src/slave/containerizer/composing.cpp ########## @@ -425,6 +425,28 @@ Future<Containerizer::LaunchResult> ComposingContainerizerProcess::_launch( } +static Try<Nothing> validateContainerInfoType(const ContainerInfo& info) Review comment: Making this a templated helper makes sense, I'll do that. Using this helper for all the other similar protobufs looks like another task of an unknown difficulty and volume;) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
