----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70161/#review213651 -----------------------------------------------------------
Bad review! Reviews applied: [70161, 70201, 70152, 70151, 70150, 70149, 70148, 70063, 70069, 70062, 70061, 70160, 70159] Error: Circular dependency detected for review 70152.Please fix the 'depends_on' field. - Mesos Reviewbot On March 8, 2019, 7:25 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70161/ > ----------------------------------------------------------- > > (Updated March 8, 2019, 7:25 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9596 > https://issues.apache.org/jira/browse/MESOS-9596 > > > Repository: mesos > > > Description > ------- > > A `QuotaConfig` is valid if the following conditions are met: > > (1) The config has a valid non-"*" role. > > (2) Resource scalar values are non-negative and finite. > > (3) If both guarantees and limits are set for a particular > resource, then guarantee <= limit for that resource. > > > Diffs > ----- > > src/master/quota.hpp 5cd2bb0e8669ee0290a4c1fe1058b87251772939 > src/master/quota.cpp 671626c01ada595d7557d5266e39a17cce243b94 > > > Diff: https://reviews.apache.org/r/70161/diff/1/ > > > Testing > ------- > > make check > dedicated test added in subsequent patches > > > Thanks, > > Meng Zhu > >
