----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70168/#review213835 -----------------------------------------------------------
Fix it, then Ship it! src/CMakeLists.txt Line 1 (original), 1 (patched) <https://reviews.apache.org/r/70168/#comment299900> Please squash this whole patch with https://reviews.apache.org/r/70169/ as we are moving code from there to here. - Benjamin Bannier On March 20, 2019, 6:36 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70168/ > ----------------------------------------------------------- > > (Updated March 20, 2019, 6:36 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9632 > https://issues.apache.org/jira/browse/MESOS-9632 > > > Repository: mesos > > > Description > ------- > > The `ServiceManager` will be used to refactor SLRP to move container > management out from SLRP. It is agnostic to CSI versions, so can be used > to manage plugin containers for both CSI v0 and v1 plugins. Most of its > logic are adapted from the SLRP code. > > > Diffs > ----- > > src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2 > src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07 > src/csi/service_manager.hpp PRE-CREATION > src/csi/service_manager.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/70168/diff/7/ > > > Testing > ------- > > Testing done later in chain. > > > Thanks, > > Chun-Hung Hsiao > >
