----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70169/#review213834 -----------------------------------------------------------
Fix it, then Ship it! Looking good. Let's squash this with https://reviews.apache.org/r/70168/. src/resource_provider/storage/provider.cpp Line 1 (original), 1 (patched) <https://reviews.apache.org/r/70169/#comment299899> Please squash this whole patch with https://reviews.apache.org/r/70168/ as we are moving code from here to there. - Benjamin Bannier On March 20, 2019, 7:03 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70169/ > ----------------------------------------------------------- > > (Updated March 20, 2019, 7:03 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9632 > https://issues.apache.org/jira/browse/MESOS-9632 > > > Repository: mesos > > > Description > ------- > > Refactored SLRP to use `ServiceManager`. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > fea623c292158deb1b4b4b9ab1ac208031471519 > src/resource_provider/storage/provider_process.hpp > a5536b3d735e01eb1c4dc52d0602d973155f3c93 > > > Diff: https://reviews.apache.org/r/70169/diff/3/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
