-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70290/#review213969
-----------------------------------------------------------
I see in the test `INTERNET_CURL_FetchManifest` we have the following Windows
specific code which I think we do not need now.
```
#ifdef __WINDOWS__
// Version 2 schema 2 image manifest test
Try<string> _s2Manifest = os::read(path::join(dir, "manifest_v2s2"));
ASSERT_SOME(_s2Manifest);
Try<docker::spec::v2_2::ImageManifest> s2Manifest =
docker::spec::v2_2::parse(_s2Manifest.get());
ASSERT_SOME(s2Manifest);
EXPECT_EQ(2u, s2Manifest->schemaversion());
#endif // __WINDOWS__
```
src/tests/uri_fetcher_tests.cpp
Lines 380 (patched)
<https://reviews.apache.org/r/70290/#comment300097>
Can we add a comment to describe why the image used in this test is a v2 s2
image?
- Qian Zhang
On March 24, 2019, 12:34 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70290/
> -----------------------------------------------------------
>
> (Updated March 24, 2019, 12:34 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Ilya Pronin, Jie Yu, and Qian Zhang.
>
>
> Bugs: MESOS-6934
> https://issues.apache.org/jira/browse/MESOS-6934
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a unit test for fetching docker manifest v2s2 image.
>
>
> Diffs
> -----
>
> src/tests/uri_fetcher_tests.cpp f8bacc0bb9e30917f0792d25f172534a0ec27a2c
>
>
> Diff: https://reviews.apache.org/r/70290/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>
