lava commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send(). URL: https://github.com/apache/mesos/pull/327#discussion_r268575980
########## File path: src/python/native_common/ext_modules.py.in ########## @@ -22,6 +22,29 @@ import sys from setuptools import Extension +class BadAutoconfSubstitutes(ValueError): + pass + +def _get_ac_subst_bool(true_subst, false_subst): + """ + This function accepts arguments which are supposedly a result + of substitution by the code in the configure script that + was generated for a boolean flag. + It either returns the value of this flag, or fails if the + combination of these "substitution results" is not valid. Review comment: If you keep this function, can you add an example to the comment? I had to read through the usages below before I understood this function. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
