----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70294/#review213993 -----------------------------------------------------------
Patch looks great! Reviews applied: [70294] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 25, 2019, 1:04 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70294/ > ----------------------------------------------------------- > > (Updated March 25, 2019, 1:04 p.m.) > > > Review request for mesos, Greg Mann and Neil Conway. > > > Repository: mesos > > > Description > ------- > > Removed a comment that implied that multiple consecutive calls > to `Master::removeSlave()` would be highly unexpected. > > Both call sites do not seem to contain any checks against > the `removed` set, so it's not clear why the comment was assuming > that. > > Barring additional clarifications, the comment seems to be more > confusing than clearing things up. > > > Diffs > ----- > > src/master/master.cpp 9c4a9e83da94535873d72c902835f229c4f96320 > > > Diff: https://reviews.apache.org/r/70294/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
