> On March 27, 2019, 11 a.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 2931 (patched) > > <https://reviews.apache.org/r/70316/diff/2/?file=2134400#file2134400line2931> > > > > Is this related to above comment block?
Yes, "the extra storage pool." > On March 27, 2019, 11 a.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 3050 (patched) > > <https://reviews.apache.org/r/70316/diff/2/?file=2134400#file2134400line3071> > > > > Let's add an assertion that the range resulting from the filter is > > actually non-empty. The "AllOf" expectation matcher should have ensured that. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70316/#review214094 ----------------------------------------------------------- On March 27, 2019, 3:45 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70316/ > ----------------------------------------------------------- > > (Updated March 27, 2019, 3:45 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9540 > https://issues.apache.org/jira/browse/MESOS-9540 > > > Repository: mesos > > > Description > ------- > > This patch renames `ImportPreprovisionedVolume` to > `CreateDestroyPreprovisionedVolume` add tests two additional scenarios: > > * `CREATE_DISK` with an unknown profile. > > * `DESTROY_DISK` with a `RAW` disk. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87 > > > Diff: https://reviews.apache.org/r/70316/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
