----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70320/#review214152 -----------------------------------------------------------
Patch looks great! Reviews applied: [70318, 70319, 70320] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 27, 2019, 5:31 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70320/ > ----------------------------------------------------------- > > (Updated March 27, 2019, 5:31 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9504 > https://issues.apache.org/jira/browse/MESOS-9504 > > > Repository: mesos > > > Description > ------- > > Replaced `Resources` with `ResourceQuantities` when > appropriate in `__allocate()`. This simplifies the > code and improves performance. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 36bf90baf413e99c1580d516dfac0f074335d322 > src/master/allocator/mesos/hierarchical.cpp > 8bc749903b8ceb09a02e260919377483479302b5 > > > Diff: https://reviews.apache.org/r/70320/diff/2/ > > > Testing > ------- > > make check > Benchmark results in r/70330 > > > Thanks, > > Meng Zhu > >
