----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70331/#review214161 -----------------------------------------------------------
src/tests/storage_local_resource_provider_tests.cpp Line 1 (original), 1 (patched) <https://reviews.apache.org/r/70331/#comment300347> This patch fails for me on top of `6276f7e73b0dbe7df49a7315cd1b83340d66f4ea` with ``` [ RUN ] StorageLocalResourceProviderTest.AgentRegisteredWithNewId unknown file: Failure Unexpected mock function call - returning directly. Function call: statusUpdate(0x7ffda68dd538, @0x7f9521a0e838 136-byte object <30-65 66-47 95-7F 00-00 00-00 00-00 00-00 00-00 3E-E8 00-00 00-00 00-00 08-5A C3-45 95-7F 00-00 60-9C 02-2C 94-7F 00-00 D0-AA 02-2C 94-7F 00-00 00-83 00-2C 94-7F 00-00 B0-A3 00-2C 94-7F 00-00 ... 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 93-8C 15-9B 21-27 D7-41 00-00 00-00 01-00 00-00 15-00 00-00 03-00 00-00>) Google Mock tried the following 3 expectations, but none matched: ../src/tests/storage_local_resource_provider_tests.cpp:1603: tried expectation #0: EXPECT_CALL(sched, statusUpdate(&driver, TaskStatusStateEq(TASK_STARTING)))... Expected arg #1: task status state eq TASK_STARTING Actual: 136-byte object <30-65 66-47 95-7F 00-00 00-00 00-00 00-00 00-00 3E-E8 00-00 00-00 00-00 08-5A C3-45 95-7F 00-00 60-9C 02-2C 94-7F 00-00 D0-AA 02-2C 94-7F 00-00 00-83 00-2C 94-7F 00-00 B0-A3 00-2C 94-7F 00-00 ... 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 93-8C 15-9B 21-27 D7-41 00-00 00-00 01-00 00-00 15-00 00-00 03-00 00-00> Expected: to be called once Actual: never called - unsatisfied and active ../src/tests/storage_local_resource_provider_tests.cpp:1604: tried expectation #1: EXPECT_CALL(sched, statusUpdate(&driver, TaskStatusStateEq(TASK_RUNNING)))... Expected arg #1: task status state eq TASK_RUNNING Actual: 136-byte object <30-65 66-47 95-7F 00-00 00-00 00-00 00-00 00-00 3E-E8 00-00 00-00 00-00 08-5A C3-45 95-7F 00-00 60-9C 02-2C 94-7F 00-00 D0-AA 02-2C 94-7F 00-00 00-83 00-2C 94-7F 00-00 B0-A3 00-2C 94-7F 00-00 ... 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 93-8C 15-9B 21-27 D7-41 00-00 00-00 01-00 00-00 15-00 00-00 03-00 00-00> Expected: to be called once Actual: never called - unsatisfied and active ../src/tests/storage_local_resource_provider_tests.cpp:1605: tried expectation #2: EXPECT_CALL(sched, statusUpdate(&driver, TaskStatusStateEq(TASK_FINISHED)))... Expected arg #1: task status state eq TASK_FINISHED Actual: 136-byte object <30-65 66-47 95-7F 00-00 00-00 00-00 00-00 00-00 3E-E8 00-00 00-00 00-00 08-5A C3-45 95-7F 00-00 60-9C 02-2C 94-7F 00-00 D0-AA 02-2C 94-7F 00-00 00-83 00-2C 94-7F 00-00 B0-A3 00-2C 94-7F 00-00 ... 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 93-8C 15-9B 21-27 D7-41 00-00 00-00 01-00 00-00 15-00 00-00 03-00 00-00> Expected: to be called once Actual: never called - unsatisfied and active ../src/tests/storage_local_resource_provider_tests.cpp:1624: Failure Failed to wait 15secs for taskFinished ../src/tests/storage_local_resource_provider_tests.cpp:1603: Failure Actual function call count doesn't match EXPECT_CALL(sched, statusUpdate(&driver, TaskStatusStateEq(TASK_STARTING)))... Expected: to be called once Actual: never called - unsatisfied and active ../src/tests/storage_local_resource_provider_tests.cpp:1604: Failure Actual function call count doesn't match EXPECT_CALL(sched, statusUpdate(&driver, TaskStatusStateEq(TASK_RUNNING)))... Expected: to be called once Actual: never called - unsatisfied and active ../src/tests/storage_local_resource_provider_tests.cpp:1605: Failure Actual function call count doesn't match EXPECT_CALL(sched, statusUpdate(&driver, TaskStatusStateEq(TASK_FINISHED)))... Expected: to be called once Actual: never called - unsatisfied and active [ FAILED ] StorageLocalResourceProviderTest.AgentRegisteredWithNewId (15986 ms) ``` - Benjamin Bannier On March 28, 2019, 6:18 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70331/ > ----------------------------------------------------------- > > (Updated March 28, 2019, 6:18 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9655 > https://issues.apache.org/jira/browse/MESOS-9655 > > > Repository: mesos > > > Description > ------- > > This patch makes the `AgentRegisteredWithNewId` SLRP test to test the > following scenarios: > > * Launch a task to access a volume imported through `CREATE_DISK`. > > * `CREATE_DISK` with a mismatched profile. > > * `DESTROY_DISK` with a `RAW` disk that has been published. > > Together with the `CreateDestroyPreprovisionedVolume` SLRP test, most > scenarios of preprovisioned volumes are now covered. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87 > > > Diff: https://reviews.apache.org/r/70331/diff/1/ > > > Testing > ------- > > sudo make check > > Run in repetition. > > > Thanks, > > Chun-Hung Hsiao > >
