----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70335/#review214190 -----------------------------------------------------------
Patch looks great! Reviews applied: [70335] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 29, 2019, 7:27 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70335/ > ----------------------------------------------------------- > > (Updated March 29, 2019, 7:27 a.m.) > > > Review request for mesos, Benjamin Bannier, Benno Evers, Chun-Hung Hsiao, > Gastón Kleiman, Joseph Wu, and Meng Zhu. > > > Bugs: MESOS-8582 > https://issues.apache.org/jira/browse/MESOS-8582 > > > Repository: mesos > > > Description > ------- > > This patch updates the master to send a framework's full > `FrameworkInfo` to the agent in the `ApplyOperationMessage`. > The agent is updated to checkpoint frameworks when applying > operations, and to unschedule GC on the meta directory when > a new framework is created. > > The test `TerminalOrphanOperationAfterMasterFailover` is > removed since this patch eliminates the case of orphan > operations relevant to that test. > > > Diffs > ----- > > src/master/master.cpp acc67d3763ddee9027e6cf375f1d495ff5805026 > src/messages/messages.proto e30ad34cc9212b05f85ba5e1d4fcfc9e49ae92c0 > src/slave/slave.hpp 2bffdc4b1e282d3c6dae2dcf23584a8a4550bf94 > src/slave/slave.cpp 5373cee5d30c2403497939eeba2ee5405117237e > src/tests/persistent_volume_tests.cpp > 7e929a5a3a92e16a5dec10206f37caebc20d66a8 > src/tests/reservation_tests.cpp cd84cd24d3587fafc01ae1861f22c47262f2d7e9 > src/tests/storage_local_resource_provider_tests.cpp > 55c9389453754227de31e0a76d32ba663cc8ca7c > > > Diff: https://reviews.apache.org/r/70335/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >
