----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70356/#review214335 -----------------------------------------------------------
Ship it! Ship It! - Andrei Budnik On April 2, 2019, 1:27 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70356/ > ----------------------------------------------------------- > > (Updated April 2, 2019, 1:27 a.m.) > > > Review request for mesos, Andrei Budnik, Gilbert Song, James Peach, and Qian > Zhang. > > > Bugs: MESOS-9529 > https://issues.apache.org/jira/browse/MESOS-9529 > > > Repository: mesos > > > Description > ------- > > If a container shares the same pid namespace as its parent and is not a > top level container. It might or might not share the same pid namespace > as the agent. In this case, we need to re-mount `/proc`. > > One caveat here is that: in the case where this container does share the > pid namespace of the agent (because its parent shares the same pid > namespace of the agent), mounting `/proc` at the same place will result > in EBUSY. > > As a result, we need to "move" (MS_MOVE) the mounts under `/proc` to a > new location and mount the `/proc` again at the old location. > > See MESOS-9529 for details. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/namespaces/pid.cpp > 5df31227454c5865ad13c0c334168938c1bc6cad > src/slave/containerizer/mesos/paths.hpp > 2dc222e8db2e27a41b5dd1da01095005d76bcd80 > src/slave/containerizer/mesos/paths.cpp > 94ab921a79ff62bd43b5c72a368ec8b3e37ef110 > > > Diff: https://reviews.apache.org/r/70356/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
