----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70353/#review214340 -----------------------------------------------------------
Ship it! We probably want to benchmark this before landing? - Meng Zhu On April 1, 2019, 4:57 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70353/ > ----------------------------------------------------------- > > (Updated April 1, 2019, 4:57 p.m.) > > > Review request for mesos and Meng Zhu. > > > Bugs: MESOS-9688 and MESOS-9691 > https://issues.apache.org/jira/browse/MESOS-9688 > https://issues.apache.org/jira/browse/MESOS-9691 > > > Repository: mesos > > > Description > ------- > > The current reservation tracking in the allocator does not take > into account hierarchical roles. As a result, when a subrole > (e.g. "a/b") has a reservation, it does not count towards the > role's (e.g. "a") quota. This patch updates the reservation > tracking for each roel to include all all subrole reservations. > > In addition, the quota consumption tracking is fixed to correctly > handle subroles. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > b9bddd31c581d8166bf6497d5d19c585b2b108a3 > > > Diff: https://reviews.apache.org/r/70353/diff/1/ > > > Testing > ------- > > make check > > Tests will be needed. > > > Thanks, > > Benjamin Mahler > >
