----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70405/#review214415 -----------------------------------------------------------
Fix it, then Ship it! Thanks for cleaning this up, Andrei. I left a small suggestions for your consideration. Feel free to drop and land. src/slave/containerizer/mesos/provisioner/docker/store.cpp Line 449 (original), 449 (patched) <https://reviews.apache.org/r/70405/#comment300617> We only depend on `this` so we can access a single `flags` member. I think just copying that value and capturing that instead would be a better approach (e.g., doesn't need to be deferred but can return ASAP). Do we expect that we'll add more or could we do that? - Benjamin Bannier On April 5, 2019, 1:53 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70405/ > ----------------------------------------------------------- > > (Updated April 5, 2019, 1:53 p.m.) > > > Review request for mesos, Benjamin Bannier, Gilbert Song, and Qian Zhang. > > > Bugs: MESOS-6934 > https://issues.apache.org/jira/browse/MESOS-6934 > > > Repository: mesos > > > Description > ------- > > Deferred lambda callback of the `moveLayers()` to the `StoreProcess` > to prevent use-after-free of the process object since the callback > refers to the `StoreProcess` class variable `flags`. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 909364d21318956ed5e4c53419479d6d38d83858 > > > Diff: https://reviews.apache.org/r/70405/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Andrei Budnik > >
