----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70419/ -----------------------------------------------------------
Review request for mesos and Benjamin Mahler. Repository: mesos Description ------- This patch refactors `Sorter::sorted` to return an abstract class `SortedCandidates` instead of a whole `vector<string>`. Callers can then use `SortedCandidates::next()` to get the next sorted candidate. This paves the way for sort optimization where sorting of the whole clients can be lazily done as callers ask for the next client. Diffs ----- src/master/allocator/mesos/hierarchical.cpp 64a076ddd29711437d539a06bb0470755828cc87 src/master/allocator/sorter/drf/sorter.hpp 91a9d668b87079158f7072780dc86bb08865166e src/master/allocator/sorter/drf/sorter.cpp 554ac84ee585d1d07048a58cf7d7d1e6586252ee src/master/allocator/sorter/random/sorter.hpp 125ce84761e4c930370912151700ddda35d7b6c1 src/master/allocator/sorter/random/sorter.cpp bbe130dbf3b158ea14f9572bc5d14200fcd85127 src/master/allocator/sorter/sorter.hpp d56a1166a9e82b034564842ac071874ec2885004 src/tests/sorter_tests.cpp 9d52a80eafb6f955386a6575875daacf5d4b4e9e Diff: https://reviews.apache.org/r/70419/diff/1/ Testing ------- make check Thanks, Meng Zhu
