----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70399/#review214459 -----------------------------------------------------------
Fix it, then Ship it! src/csi/v0_utils.cpp Lines 29-34 (patched) <https://reviews.apache.org/r/70399/#comment300667> These variable names all look very similar and are hard to distinguish. How about `s/t2s/from/`, `s/t1s/to/` and e.g., `s/t2/value/` (I don't think we gain much by `t2s` and `t2` being named alike)? Here and below. - Benjamin Bannier On April 5, 2019, 8:26 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70399/ > ----------------------------------------------------------- > > (Updated April 5, 2019, 8:26 a.m.) > > > Review request for mesos, Benjamin Bannier and Jan Schlicht. > > > Bugs: MESOS-9627 > https://issues.apache.org/jira/browse/MESOS-9627 > > > Repository: mesos > > > Description > ------- > > Added helpers to evolve/devolve repeated CSI v0 `VolumeCapability`s. > > > Diffs > ----- > > src/csi/v0_utils.hpp 46a5f138c1d251915065cbde60eeee2fee14b06e > src/csi/v0_utils.cpp a95d240fb1eac474d2c9d88e96881d0f992d5c8a > > > Diff: https://reviews.apache.org/r/70399/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
