----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70401/#review214462 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Bannier On April 5, 2019, 8:29 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70401/ > ----------------------------------------------------------- > > (Updated April 5, 2019, 8:29 a.m.) > > > Review request for mesos, Benjamin Bannier and Jan Schlicht. > > > Bugs: MESOS-9623 > https://issues.apache.org/jira/browse/MESOS-9623 > > > Repository: mesos > > > Description > ------- > > We rename `volume_attributes` to `volume_context` and `publish_info` to > `publish_context` in `state.proto` to match the new CSI v1 standard to > avoid confusions. Since this protobuf message is only used for > checkpointing and the binary format does not change, there will be no > compatibility issue. > > > Diffs > ----- > > src/csi/state.proto b7213ed0f344eea30bdd97bcf40719b19778c1fb > src/csi/v0_volume_manager.cpp 7de900095bb86c207869c599c17ca08838e722be > src/csi/v0_volume_manager_process.hpp > 88073e423559f1fc5d171dbbac26e46472589e5a > > > Diff: https://reviews.apache.org/r/70401/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
