----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70431/#review214510 -----------------------------------------------------------
Patch looks great! Reviews applied: [70313, 70314, 70315, 70316, 70331, 70245, 70168, 70247, 70248, 70213, 70214, 70216, 70215, 70217, 70284, 70222, 70285, 70223, 70225, 70302, 70303, 70321, 70360, 70361, 70362, 70363, 70399, 70400, 70401, 70402, 70403, 70404, 70427, 70428, 70431] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 8, 2019, 11:09 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70431/ > ----------------------------------------------------------- > > (Updated April 8, 2019, 11:09 p.m.) > > > Review request for mesos, Benjamin Bannier and Jan Schlicht. > > > Bugs: MESOS-9627 > https://issues.apache.org/jira/browse/MESOS-9627 > > > Repository: mesos > > > Description > ------- > > This patch enables the unit test to test against CSI v1 through the > following changes: > > * The forwarding mode of the test CSI plugin now respects the > `--api_version` option. When specified, only requests of the proper > CSI version will be forwarded. > > * The expectations of `CreateVolume` and `DeleteVolume` calls in the > unit tests are parameterized against the CSI version string. > > * The mock CSI plugin now provides a default implementation for the > `GetCapacity` call so the unit test can be simplified. > > > Diffs > ----- > > src/examples/test_csi_plugin.cpp 4321f8f16cb12018f008002cdc5c9002a055e2b7 > src/tests/mock_csi_plugin.cpp 10245705ab39872da0fef1afd02213e2c7f345cb > src/tests/storage_local_resource_provider_tests.cpp > da8db41b867d04b4236ad3515811fc00318c619c > > > Diff: https://reviews.apache.org/r/70431/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
