-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70439/
-----------------------------------------------------------
(Updated April 10, 2019, 4:08 a.m.)
Review request for mesos, Benjamin Bannier and Greg Mann.
Changes
-------
Fixed cgroups cleanup issue.
Bugs: MESOS-9719
https://issues.apache.org/jira/browse/MESOS-9719
Repository: mesos
Description (updated)
-------
The test is flaky because:
* It assumes the mock RP never reregisters, which might not be true.
* It does not wait for the task and executor to be reaped, which would
lead to a race between containerizer destroy and test teardown and
cause cgroups cleanup to fail.
* It fast-forwards the clock, which might lead to containerizer
timed out to wait for all nested containers to be killed.
* It assumes that the framework only receives two status updates,
which might not be true.
Diffs (updated)
-----
src/tests/mesos.hpp 1a6d826781ea6f3d47b852c5deca3012271420fe
src/tests/slave_tests.cpp 528a25a837513f153de2a5e89897440144385633
Diff: https://reviews.apache.org/r/70439/diff/3/
Changes: https://reviews.apache.org/r/70439/diff/2-3/
Testing (updated)
-------
Ran as root for 200 iterations under stress w/ await timeout set to 1mins.
Thanks,
Chun-Hung Hsiao
