> On April 4, 2019, 9:53 p.m., Gastón Kleiman wrote: > > src/master/master.hpp > > Lines 1194-1195 (patched) > > <https://reviews.apache.org/r/70379/diff/1/?file=2137244#file2137244line1194> > > > > I'd write something like this: > > > > ``` > > Validates that the principal provided on resubscription matches the one > > already known by the master. > > ```
This code is not a separate method anymore. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70379/#review214382 ----------------------------------------------------------- On April 10, 2019, 3:35 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70379/ > ----------------------------------------------------------- > > (Updated April 10, 2019, 3:35 p.m.) > > > Review request for mesos and Gastón Kleiman. > > > Bugs: MESOS-2842 > https://issues.apache.org/jira/browse/MESOS-2842 > > > Repository: mesos > > > Description > ------- > > Added validation that the principal stays the same on resubscription. > > > Diffs > ----- > > src/master/master.cpp ad54ae217863a08f4e6d743b39c176b171353084 > > > Diff: https://reviews.apache.org/r/70379/diff/3/ > > > Testing > ------- > > make check > > Now the two failing tests from https://reviews.apache.org/r/70377/ pass. > > > Thanks, > > Andrei Sekretenko > >
