----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70450/#review214561 -----------------------------------------------------------
Fix it, then Ship it! src/slave/http.cpp Lines 794 (patched) <https://reviews.apache.org/r/70450/#comment300734> How about: // We return early here before doing any validation because currently this proto contains // dummy values for framework and executor ids (which is safe). See TODO inside `heartbeat()` in `src/executor/executor.cpp`. - Vinod Kone On April 11, 2019, 12:02 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70450/ > ----------------------------------------------------------- > > (Updated April 11, 2019, 12:02 a.m.) > > > Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-9727 > https://issues.apache.org/jira/browse/MESOS-9727 > > > Repository: mesos > > > Description > ------- > > This silences a '400 Bad Request' response by the agent whenever an > executor sends a HEARTBEAT call. These HEARTBEATs do not include a > valid value for required fields (FrameworkID and ExecutorID) because > they are not known by the library generating the HEARTBEATs. > > The error is harmless because HEARTBEAT calls do not have any effect > besides generating traffic. > > > Diffs > ----- > > src/executor/executor.cpp e9439da2afec3746403a1fc8fbc4420a67f8e509 > src/slave/http.cpp d66ae520f68b783caea8937a1a753608099d5926 > > > Diff: https://reviews.apache.org/r/70450/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >
