> On April 16, 2019, 7:23 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/provisioner/store.hpp > > Line 49 (original), 49 (patched) > > <https://reviews.apache.org/r/70483/diff/1/?file=2139611#file2139611line49> > > > > This comment seems not accurate, this field should be either Docker v1 > > image manifest or Docker v2 s2 image configuration.
I think both v2s2 and v2s1 is compatible with the old docker v1 spec https://github.com/docker/docker/blob/master/image/spec/v1.md the protobuf naming `v1::ImageManifest` was confusing though. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70483/#review214683 ----------------------------------------------------------- On April 15, 2019, 11:07 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70483/ > ----------------------------------------------------------- > > (Updated April 15, 2019, 11:07 p.m.) > > > Review request for mesos, Andrei Budnik, Jie Yu, Qian Zhang, and Zhitao Li. > > > Bugs: MESOS-9704 > https://issues.apache.org/jira/browse/MESOS-9704 > > > Repository: mesos > > > Description > ------- > > Added docker manifest v2s2 config to 'ImageInfo'. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/store.hpp > a4ae00e1d95f738f1489afbb0fbde9e1d9dafff6 > > > Diff: https://reviews.apache.org/r/70483/diff/1/ > > > Testing > ------- > > > Thanks, > > Gilbert Song > >
