----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70596/#review215058 -----------------------------------------------------------
Fix it, then Ship it! Ship It! src/tests/storage_local_resource_provider_tests.cpp Line 1 (original), 1 (patched) <https://reviews.apache.org/r/70596/#comment301442> Please make sure your commit message passes the linter (e.g., needs to be wrapped at 72 chars). src/tests/storage_local_resource_provider_tests.cpp Line 1795 (original), 1795 (patched) <https://reviews.apache.org/r/70596/#comment301444> Could we move this into a test class-specific constant? Here and below. - Benjamin Bannier On May 3, 2019, 11:09 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70596/ > ----------------------------------------------------------- > > (Updated May 3, 2019, 11:09 p.m.) > > > Review request for mesos, Benjamin Bannier and Jan Schlicht. > > > Bugs: MESOS-9765 > https://issues.apache.org/jira/browse/MESOS-9765 > > > Repository: mesos > > > Description > ------- > > Raised the task memory to 128MB (which are the value used in most persistent > volume tests) in all SLRP tests that launch tasks to avoid OOM. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > ec2222d7aeef1cb3d1a5b4b3419dfd912d41a8c6 > > > Diff: https://reviews.apache.org/r/70596/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
