----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70550/#review215072 -----------------------------------------------------------
include/mesos/authorizer/acls.proto Lines 135-143 (original), 135-152 (patched) <https://reviews.apache.org/r/70550/#comment301472> Why do we need the two idential messages? Seems like this needs to be spelled out in the comments and in the commit description, as it's not obvious - Benjamin Mahler On April 25, 2019, 11:14 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70550/ > ----------------------------------------------------------- > > (Updated April 25, 2019, 11:14 p.m.) > > > Review request for mesos, Andrei Sekretenko, Benjamin Mahler, and Till > Toenshoff. > > > Bugs: MESOS-9640 > https://issues.apache.org/jira/browse/MESOS-9640 > > > Repository: mesos > > > Description > ------- > > Also added a test. > > > Diffs > ----- > > include/mesos/authorizer/acls.proto > 85a3979bc02ab0145a0934f29eeef7bb65f3c42c > include/mesos/authorizer/authorizer.hpp > a86a6eeb592adfc267dcf3faef40e8da3471feaf > src/authorizer/local/authorizer.cpp > ec86f053357e4bc85532ea4073b57b272ffc74fe > src/tests/authorization_tests.cpp cad76f664c02dc778884d9850184b672e28f5fee > > > Diff: https://reviews.apache.org/r/70550/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
