-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70583/
-----------------------------------------------------------
(Updated May 7, 2019, 10:15 a.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Fixed summary and description.
Summary (updated)
-----------------
Eliminated copying 'suppressedRoles' and changed its type.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description (updated)
-------
This patch changes the type of `suppressedRoles` argument of
`Master::_subscribe()` method from `const set<string>&` to
`RepeatedFieldPtr<string>&&` and uses move semantics to eliminate copying.
Change from `set<string>` to `RepeatedPtrField<string>` is required due to the
need to pass the suppressed roles into
`Master::validateFrameworkSubscription()` once again. This need arises in the
dependent patch: https://reviews.apache.org/r/70583/.
Move semantics is employed to avoid copying `suppressedRoles` in the deferred
call.
Diffs
-----
src/master/http.cpp 765bbf1442f26dcc08c5404f714b6a2ef6616ed8
src/master/master.hpp 7d9732f1e432f6f0290d234242864cbdbf381fa8
src/master/master.cpp a8ee6297e1587c160a47b806914d3c3aa4f35cd7
Diff: https://reviews.apache.org/r/70583/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko
