> On May 6, 2019, 5:45 p.m., Benjamin Mahler wrote:
> > site/source/blog/2019-05-02-mesos-1-8-0-released.md
> > Lines 16-49 (patched)
> > <https://reviews.apache.org/r/70598/diff/1/?file=2143175#file2143175line16>
> >
> >     These snippets should probably be in triple backtick sections to ensure 
> > they are monospaced and lined up when rendered?

Having 4 leading spaces is actually an alternative syntax for monospace blocks. 
(at least for my local website preview)


> On May 6, 2019, 5:45 p.m., Benjamin Mahler wrote:
> > site/source/blog/2019-05-02-mesos-1-8-0-released.md
> > Lines 38-49 (patched)
> > <https://reviews.apache.org/r/70598/diff/1/?file=2143175#file2143175line38>
> >
> >     is this lines of code? commits touching the files? something else?
> >     
> >     the subfolder stuff seems a bit bizarre here, for example, is the 
> > number for src/ `src - src subfolders shown above`?
> >     
> >     Perhaps a hierarchically displayed version will be less prone to 
> > confusion?
> >     
> >     ```
> >         30.2% src/
> >               11.0% src/master
> >                7.8% src/cli
> >         4.0% support/
> >                3.7% support/python3/
> >     
> >     ```
> >     
> >     But then 11% here isn't clear if it's 11% of src's 30% or 11% of the 
> > overall changes.
> >     
> >     I don't have any good suggestions, but I think the summary stats are 
> > interesting. Curious how other projects display them..

Good idea, the original numbers were non-cumulative, but I agree that 
hierarchical, cumulative numbers are easier to understand.


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70598/#review215065
-----------------------------------------------------------


On May 7, 2019, 6:23 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70598/
> -----------------------------------------------------------
> 
> (Updated May 7, 2019, 6:23 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added blogpost for 1.8.0 release.
> 
> 
> Diffs
> -----
> 
>   site/source/blog/2019-05-02-mesos-1-8-0-released.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70598/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Reply via email to