> On April 24, 2019, 7:52 p.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 3237 (patched) > > <https://reviews.apache.org/r/70533/diff/1/?file=2140833#file2140833line3237> > > > > What does updateFramework do if the changes are not allowed? Crash? > > > > Seems like we should be CHECKing that it succeeded or something..
Now it simply crashes - and validity of the framework_info is ensured by the code executed before it. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/#review214864 ----------------------------------------------------------- On May 17, 2019, 3:18 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70533/ > ----------------------------------------------------------- > > (Updated May 17, 2019, 3:18 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7258 > https://issues.apache.org/jira/browse/MESOS-7258 > > > Repository: mesos > > > Description > ------- > > This patch is based on the previous implementation attempt: > https://reviews.apache.org/r/66229/ > > > Diffs > ----- > > src/master/http.cpp c2c7b9b65bd66679420f62d37b01d90e3692c71d > src/master/master.hpp c523c937e294eaffe0e58306c267770c119c9f42 > src/master/master.cpp c72b92656dddca63ee89abf676da66bd76f58a6d > src/master/validation.cpp 9fb0850987ce385d345302cac9721adead7181b8 > > > Diff: https://reviews.apache.org/r/70533/diff/6/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
