lava commented on issue #335: Return early in fetcher if no uris are specified. URL: https://github.com/apache/mesos/pull/335#issuecomment-495281497 Hey @carlonelong , thanks for contributing! Your patch looks reasonable to me, however when I ran it through our CI it seemed to break a few unit tests, in particular: Test Name | Duration | Age -- | -- | -- mesos-ec2-ubuntu-16.04-SSL.Mesos.DockerContainerizerTest.ROOT_DOCKER_UNPRIVILEGED_USER_NonRootSandbox | 6 sec | 1 mesos-ec2-ubuntu-16.04-SSL.Mesos.MesosContainerizerExecuteTest.ROOT_UNPRIVILEGED_USER_SandboxFileOwnership | 0.1 sec | 1 mesos-ec2-ubuntu-16.04-SSL.Mesos.MesosContainerizerDestroyTest.DestroyWhileFetching | 15 sec | 1 mesos-ec2-ubuntu-16.04-SSL.Mesos.ProvisionerDockerTest.ROOT_INTER (and the same for debian9, centos6/7, ubuntu 14.04, etc.) I did not have the time to investigate what exactly is causing these tests to fail, but I think this will need to be investigated before we can commit the patch. Best regards, Benno
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
